Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Admin sidebar navigation #26958

Merged
merged 3 commits into from
Sep 28, 2022
Merged

[FIX] Admin sidebar navigation #26958

merged 3 commits into from
Sep 28, 2022

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Sep 27, 2022

Proposed changes (including videos or screenshots)

MKP-125

Fix the behavior of the admin sidebar, it didn't activate its options properly on pages that had sub-routes.
Demo gif:
sidebar-bug

Issue(s)

Steps to test or reproduce

Further comments

@rique223 rique223 changed the title [Fix] Admin sidebar navigation [FIX] Admin sidebar navigation Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #26958 (bcc2e57) into develop (3a2b6da) will increase coverage by 0.83%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26958      +/-   ##
===========================================
+ Coverage    40.15%   40.99%   +0.83%     
===========================================
  Files          826      801      -25     
  Lines        18373    17920     -453     
  Branches      2019     1960      -59     
===========================================
- Hits          7378     7346      -32     
+ Misses       10698    10276     -422     
- Partials       297      298       +1     
Flag Coverage Δ
e2e 40.99% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review September 27, 2022 18:02
@juliajforesti juliajforesti requested a review from a team as a code owner September 27, 2022 18:02
Copy link
Contributor

@rique223 rique223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine. Thanks a lot for the help, Julia.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 28, 2022
@ggazzo ggazzo merged commit a2595bb into develop Sep 28, 2022
@ggazzo ggazzo deleted the fix/admin-sidebar-navigation branch September 28, 2022 19:46
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants